Skip to content

Fixing imread() function 16 bit APNG reading problem#27087

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:apng_CV_16U
Mar 20, 2025
Merged

Fixing imread() function 16 bit APNG reading problem#27087
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:apng_CV_16U

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

@sturkmen72 sturkmen72 commented Mar 17, 2025

closes #27073

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72 sturkmen72 mentioned this pull request Mar 17, 2025
Merged
@sturkmen72 sturkmen72 marked this pull request as draft March 18, 2025 00:42
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 18, 2025
@asmorkalov asmorkalov requested review from asmorkalov and vrabaud and removed request for vrabaud March 19, 2025 06:28
vrabaud
vrabaud reviewed Mar 19, 2025
View reviewed changes
@sturkmen72 sturkmen72 marked this pull request as ready for review March 19, 2025 18:10
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Mar 20, 2025

@vrabaud Do you have any issues with the solution? I want to merge the pr.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

sturkmen72 commented Mar 20, 2025

Note: There is a bug in grfmt_spng.cpp about reading 16 bit png images. I will provide a fix later.

vrabaud
vrabaud approved these changes Mar 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmorkalov LGTM now

@asmorkalov asmorkalov merged commit 41e3fcc into opencv:4.x Mar 20, 2025
69 of 82 checks passed
@sturkmen72 sturkmen72 deleted the apng_CV_16U branch March 20, 2025 14:58
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrabaud vrabaud vrabaud approved these changes

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@vrabaud vrabaud

Labels

bug category: imgcodecs

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

imread() function APNG reading problem

3 participants

@sturkmen72 @asmorkalov @vrabaud