Add RISC-V HAL implementation for cv::threshold and cv::adaptiveThreshold#27072
Merged
asmorkalov merged 4 commits intoopencv:4.xfrom Mar 18, 2025
Merged
Add RISC-V HAL implementation for cv::threshold and cv::adaptiveThreshold#27072asmorkalov merged 4 commits intoopencv:4.xfrom
asmorkalov merged 4 commits intoopencv:4.xfrom
Conversation
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Contributor
Author
|
I will investigate the test failure soon. |
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Contributor
Author
|
@asmorkalov Fixed, please re-run checks. |
Contributor
|
There are several groups of perf tests for threshold (Muse Pi v 30, gcc 14.2): OTSU: Generic threshold with CPU and OpenCL: Adaptive threshold: |
asmorkalov
approved these changes
Mar 17, 2025
Contributor
|
@fengyuentau @mshabunin Do you have any remarks? I want to merge the PR. |
fengyuentau
approved these changes
Mar 18, 2025
Member
fengyuentau
left a comment
There was a problem hiding this comment.
My performance results (K1 vs RK3568): perf-threshold.zip
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements
cv_hal_threshold_otsuandcv_hal_adaptiveThresholdusing native intrinsics, optimizing the performance ofcv::threshold(THRESH_OTSU)andcv::adaptiveThreshold.Since UI is as fast as HAL
cv_hal_rvv::threshold::thresholdsocv_hal_thresholdis not redirected, but this part of HAL is keeped becausecv_hal_threshold_otsudepends on it.Tested on MUSE-PI (Spacemit X60) for both gcc 14.2 and clang 20.0.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.