Skip to content

Fix some vectorized loop conditions.#27055

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
hanliutong:UI-loop-condition
Mar 13, 2025
Merged

Fix some vectorized loop conditions.#27055
asmorkalov merged 1 commit intoopencv:4.xfrom
hanliutong:UI-loop-condition

Conversation

@hanliutong
Copy link
Copy Markdown
Contributor

This patch relax the loop condition to process the final batch.

Example:

If and only if length is an integer multiple of step, the original code will miss the last batch of vectorizable data and use the following scalar loop, although the result will be correct.

--- for (int i = 0; i < length - step; i += step)
+++ for (int i = 0; i <= length - step; i += step)

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 13, 2025
@asmorkalov asmorkalov merged commit b129abf into opencv:4.x Mar 13, 2025
19 of 28 checks passed
@hanliutong hanliutong deleted the UI-loop-condition branch March 13, 2025 12:01
@asmorkalov asmorkalov mentioned this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants