Fix RISC-V HAL solve/SVD and BGRtoLab#27046
Conversation
|
cc @asmorkalov This can prevent potential test failure in 5.x. |
|
cc @mshabunin |
2b74e3e to
639195d
Compare
|
@amane-ame , please resolve merge conflict. |
|
@mshabunin Done. |
|
roundeven, roundevenf, roundevenl are available since C++23. Not sure if it's universal solution. @mshabunin What so you think? |
|
My performance results perf.zip |
|
@amane-ame I suggest you to solve conflicts with the following cli git commands instead of the GitHub webpage tool to ensure that your commits are continuous in your branch. |
|
@fengyuentau Uh, rebase will mess up the order of commits and comments in PR, because GitHub sorts them by commit date. If you are okay with this, it's fine. |
Let's restore |
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
41cfb97 to
e214a22
Compare
|
@mshabunin I can use |
|
@amane-ame , how does it affect performance? Or is the table initialized just once and it doesn't matter much? I thought that something like this would be good from both performance and safety standpoints: int old_mode = fesetround(...);
// init whole table using rint
fesetround(old_mode); |
|
@mshabunin |
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
66e08c5 to
703105b
Compare
Closes #27044.
Also suppressed some warnings in other HAL.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.