Add RISC-V HAL implementation for cv::filter series#27026
Merged
asmorkalov merged 7 commits intoopencv:4.xfrom Mar 11, 2025
Merged
Add RISC-V HAL implementation for cv::filter series#27026asmorkalov merged 7 commits intoopencv:4.xfrom
asmorkalov merged 7 commits intoopencv:4.xfrom
Conversation
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
fengyuentau
reviewed
Mar 10, 2025
Member
fengyuentau
left a comment
There was a problem hiding this comment.
Could you attach the source of the algorithm?
Contributor
Author
It was copied from the Carotene (ARM HAL) implementation, I would add some comments on it later. |
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Contributor
|
Hm, I do not see speedup. I'll recheck and return back. |
Contributor
|
My fault. I re-run the test. Details |
Contributor
|
asmorkalov
approved these changes
Mar 11, 2025
Contributor
|
@fengyuentau Do you have review notes for the PR? I want to merge it. |
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
Member
|
My performance results (K1 vs RK3568): |
fengyuentau
approved these changes
Mar 11, 2025
Co-authored-by: Liutong HAN <liutong2020@iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements
cv_hal_filter,cv_hal_sepFilterandcv_hal_morphusing native intrinsics, optimizing the performance ofcv::filter2D/cv::sepFilter/cv::Sobel/cv::Scharrfor3x3/5x5kernels andcv::erode/cv::dilate/cv::morphologyExfor3x3kernels.Tested on MUSE-PI (Spacemit X60) for both gcc 14.2 and clang 20.0.
View the full perf table here: hal_rvv_filter.pdf
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.