Optimize camera matrix undistortion#27001
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Mar 11, 2025
Merged
Conversation
Contributor
Author
|
In my opinion it should also be possible to reduce the |
Contributor
|
The idea looks good in general, but I propose to refactor a bit:
|
Contributor
Author
|
The problem with using several loops is that it reduces readability for a very low computational benefit (and i'm not sure if the compiler is already able to optimize the current solution). Below would be an approach without the continue. Which version do you prefer? |
asmorkalov
approved these changes
Mar 10, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use only image contour for camera matrix undistortion.
For inner and outer rectangles of the undistorted image only the image border should be necessary when standard distortion models are used. Using inner image points notably slows down the process since more points need to be undistorted (81 vs 32).