Skip to content

fix Logical defect in FilterSpecklesImpl#26996

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
shyama7004:outofBound
Mar 3, 2025
Merged

fix Logical defect in FilterSpecklesImpl#26996
asmorkalov merged 2 commits intoopencv:4.xfrom
shyama7004:outofBound

Conversation

@shyama7004
Copy link
Copy Markdown
Contributor

Fixes : #24963

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

The patch looks good to me, but I propose to comment the pointer arithmetic and buffer sizes to make the code more readable.

@asmorkalov asmorkalov self-assigned this Mar 3, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Mar 3, 2025
@shyama7004
Copy link
Copy Markdown
Contributor Author

The patch looks good to me, but I propose to comment the pointer arithmetic and buffer sizes to make the code more readable.

Ok, will do that.

@asmorkalov asmorkalov merged commit 3f1e7fc into opencv:4.x Mar 3, 2025
27 of 28 checks passed
@shyama7004 shyama7004 deleted the outofBound branch March 3, 2025 12:15
@asmorkalov asmorkalov mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical defect in FilterSpecklesImpl

2 participants