Skip to content

Optimize undistort points#26988

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
DanBmh:opt_undistort
Mar 3, 2025
Merged

Optimize undistort points#26988
asmorkalov merged 3 commits intoopencv:4.xfrom
DanBmh:opt_undistort

Conversation

@DanBmh
Copy link
Copy Markdown
Contributor

@DanBmh DanBmh commented Feb 27, 2025

Skips unnecessary rotation with identity matrix if no R or P mats are given.

@DanBmh
Copy link
Copy Markdown
Contributor Author

DanBmh commented Feb 27, 2025

Not tested yet, I hope the CI pipeline will test it...

@asmorkalov
Copy link
Copy Markdown
Contributor

  [1148/2134] Building CXX object modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/fisheye.cpp.o
  FAILED: modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/fisheye.cpp.o 
  /usr/bin/ccache /usr/bin/c++  -DCVAPI_EXPORTS -D_USE_MATH_DEFINES -D__OPENCV_BUILD=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I3rdparty/ippicv/ippicv_lnx/icv/include -I3rdparty/ippicv/ippicv_lnx/iw/include -I/home/ci/opencv/modules/calib3d/include -Imodules/calib3d -I/home/ci/opencv/modules/core/include -I/home/ci/opencv/modules/flann/include -I/home/ci/opencv/modules/imgproc/include -I/home/ci/opencv/modules/features2d/include -isystem . -isystem /usr/include/eigen3 -fsigned-char -W -Wall -Wreturn-type -Wnon-virtual-dtor -Waddress -Wsequence-point -Wformat -Wformat-security -Wmissing-declarations -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wuninitialized -Wsuggest-override -Wno-delete-non-virtual-dtor -Wno-comment -Wimplicit-fallthrough=3 -Wno-strict-overflow -fdiagnostics-show-option -pthread -fomit-frame-pointer -ffunction-sections -fdata-sections  -msse3 -fvisibility=hidden -fvisibility-inlines-hidden -O3 -DNDEBUG  -DNDEBUG -fPIC   -std=c++11 -MD -MT modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/fisheye.cpp.o -MF modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/fisheye.cpp.o.d -o modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/fisheye.cpp.o -c /home/ci/opencv/modules/calib3d/src/fisheye.cpp
  /home/ci/opencv/modules/calib3d/src/fisheye.cpp: In function 'void cv::fisheye::undistortPoints(cv::InputArray, cv::OutputArray, cv::InputArray, cv::InputArray, cv::InputArray, cv::InputArray, cv::TermCriteria)':
  /home/ci/opencv/modules/calib3d/src/fisheye.cpp:490:23: warning: variable 'fi' set but not used [-Wunused-but-set-variable]
    490 |                 Vec2d fi = pu;
        |                       ^~
  /home/ci/opencv/modules/calib3d/src/fisheye.cpp:494:27: error: 'fi' was not declared in this scope; did you mean 'pi'?
    494 |                 dstf[i] = fi;
        |                           ^~
        |                           pi
  /home/ci/opencv/modules/calib3d/src/fisheye.cpp:496:27: error: 'fi' was not declared in this scope; did you mean 'pi'?
    496 |                 dstd[i] = fi;
        |                           ^~
        |                           pi
  [1149/2134] Building CXX object modules/calib3d/CMakeFiles/opencv_calib3d.dir/src/undistort.dispatch.cpp.o
  ninja: build stopped: subcommand failed.

@asmorkalov
Copy link
Copy Markdown
Contributor

The optimization makes sense. Thanks for the contribution. Please fix build issues to go ahead.

@asmorkalov asmorkalov self-assigned this Mar 3, 2025
@asmorkalov asmorkalov merged commit 8a24d41 into opencv:4.x Mar 3, 2025
28 checks passed
@DanBmh DanBmh deleted the opt_undistort branch March 3, 2025 14:25
@asmorkalov asmorkalov mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants