Skip to content

Refactor ArucoDetector::ArucoDetectorImpl::filterTooCloseCandidates#26976

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:refactor-ArucoDetector-ArucoDetectorImpl-filterTooCloseCandidates
Mar 11, 2025
Merged

Refactor ArucoDetector::ArucoDetectorImpl::filterTooCloseCandidates#26976
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:refactor-ArucoDetector-ArucoDetectorImpl-filterTooCloseCandidates

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

@MaximSmolskiy MaximSmolskiy commented Feb 24, 2025

Pull Request Readiness Checklist

Related to #26968

Made the ArucoDetector::ArucoDetectorImpl::filterTooCloseCandidates method more unified and easier to understand.
Before - contours after the grouping stage can be in two states:

  1. contained in groupedCandidates and isSelectedContour = false (group of several contours)
  2. isSelectedContour = true (one independent contour).

But we can create a separate group for one independent contour - all contours will be in the same state and further processing code is already adapted for this and will be more unified.

These changes will help me make it easier to make changes in #26968 to fix failed tests.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: objdetect cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Feb 24, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 25, 2025

Should it be merged before #26968, right?

@MaximSmolskiy
Copy link
Copy Markdown
Contributor Author

Should it be merged before #26968, right?

Yes

@asmorkalov asmorkalov self-requested a review February 25, 2025 10:04
@asmorkalov asmorkalov self-assigned this Feb 25, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 25, 2025
@asmorkalov asmorkalov merged commit 1f63b98 into opencv:4.x Mar 11, 2025
21 of 28 checks passed
@MaximSmolskiy MaximSmolskiy deleted the refactor-ArucoDetector-ArucoDetectorImpl-filterTooCloseCandidates branch March 11, 2025 13:15
@asmorkalov asmorkalov mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: objdetect cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants