Skip to content

Migrate remaning OpenVX integrations to OpenVX HAL (imgproc)#26911

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/openvx_hal_imgproc
Feb 17, 2025
Merged

Migrate remaning OpenVX integrations to OpenVX HAL (imgproc)#26911
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/openvx_hal_imgproc

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Feb 12, 2025 •
edited
Loading

Depends on #26903

Not covered with HAL:

  • accumulate
  • calcHist
  • goodFeaturesToTrack calls vxuHarrisCorners.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added optimization cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Feb 12, 2025
@asmorkalov asmorkalov changed the title WIP: Migrate remaning OpenVX integrations to OpenVX HAL (imgproc) #26907 WIP: Migrate remaning OpenVX integrations to OpenVX HAL (imgproc) Feb 13, 2025
@asmorkalov asmorkalov force-pushed the as/openvx_hal_imgproc branch from 08223fc to 5b828d5 Compare February 13, 2025 09:55
@asmorkalov asmorkalov changed the title WIP: Migrate remaning OpenVX integrations to OpenVX HAL (imgproc) Migrate remaning OpenVX integrations to OpenVX HAL (imgproc) Feb 13, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 13, 2025
@asmorkalov asmorkalov force-pushed the as/openvx_hal_imgproc branch from 0558fd8 to ef6501b Compare February 14, 2025 09:44
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Feb 14, 2025

@opencv-alalek @mshabunin Could you take a look?

@asmorkalov
Move OpenVX integrations to imgproc to OpenVX HAL
acc9084 
Covered functions:
- medianBlur
- Sobel
- Canny
- pyrDown
- BoxFilter
- equalizeHist
- GaussianBlur
- remap
- threshold
@asmorkalov asmorkalov force-pushed the as/openvx_hal_imgproc branch from ef6501b to acc9084 Compare February 15, 2025 06:56
mshabunin
mshabunin approved these changes Feb 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Though currently I can not check the build. Perhaps we'll need to add OVX builder to the nightly CI jobs eventually.

@opencv-alalek opencv-alalek removed their request for review February 15, 2025 23:26
@asmorkalov asmorkalov merged commit 680fd4d into opencv:4.x Feb 17, 2025
25 of 29 checks passed
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

Assignees

@mshabunin mshabunin

Labels

cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) optimization

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @mshabunin