Skip to content

Fix _DEBUG/NDEBUG handling across modules #26908

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
shyama7004:_DEBUG/NDEBUG
Feb 12, 2025
Merged

Fix _DEBUG/NDEBUG handling across modules #26908
asmorkalov merged 1 commit intoopencv:4.xfrom
shyama7004:_DEBUG/NDEBUG

Conversation

@shyama7004
Copy link
Copy Markdown
Contributor

@shyama7004 shyama7004 commented Feb 11, 2025

Fixes : #26151

NDEBUG macro is standard and associated with assert(): https://en.cppreference.com/w/c/error/assert

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: core cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Feb 12, 2025
@asmorkalov asmorkalov self-requested a review February 12, 2025 05:17
@asmorkalov asmorkalov self-assigned this Feb 12, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 12, 2025
@asmorkalov asmorkalov merged commit 62658fb into opencv:4.x Feb 12, 2025
27 of 28 checks passed
@shyama7004 shyama7004 deleted the _DEBUG/NDEBUG branch February 12, 2025 05:22
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: core cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

change condition of CV_DbgAssert from _DEBUG to NDEBUG

2 participants