RISC-V: error message in the toolchain file when compiler is not found#26898
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Feb 14, 2025
Merged
RISC-V: error message in the toolchain file when compiler is not found#26898asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
| set(TOOLCHAIN_COMPILER_LOCATION_HINT PATHS /opt/riscv/bin ENV PATH) | ||
| endif() | ||
|
|
||
| if(NOT DEFINED CMAKE_C_COMPILER) |
Contributor
There was a problem hiding this comment.
Why is check removed?
Contributor
Author
There was a problem hiding this comment.
I assume that find_program already incorporates such check (https://cmake.org/cmake/help/latest/command/find_program.html). I.e. it will only work if its target variable has not been set. There might be difference in behavior when variable has been defined to some specific values (OFF? FALSE?), but I think it wouldn't be critical.
opencv-alalek
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiler couldn't be found, user got the following cryptic message:
Also simplified
find_program- it should not rewrite existing cache variables anyways.