Use HAL for cv::mean function too#26895
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Feb 12, 2025
Merged
Conversation
mshabunin
reviewed
Feb 11, 2025
dd0dc55 to
54fcd0c
Compare
54fcd0c to
7aaada4
Compare
mshabunin
reviewed
Feb 12, 2025
|
|
||
| CV_IPP_RUN(IPP_VERSION_X100 >= 700, ipp_mean(src, mask, s), s) | ||
|
|
||
| if (src.isContinuous() && mask.isContinuous()) |
Contributor
There was a problem hiding this comment.
Usually we put HAL call before IPP.
mshabunin
approved these changes
Feb 12, 2025
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Overall looks good to me with two comments:
- IPP is called before HAL, so we won't be able to override this function on x86_64 platforms (we can leave it this way if we are going to move IPP to HAL soon)
- name of the macro can be discussed -
CALL_HAL_RET_?CALL_HAL_RET_VA? Or is RET2 ok?
Contributor
Author
|
IPP will be covered in #26880. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.