Skip to content

Do not rely on cv namespace in HAL#26878

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/respect_namespace_hal
Feb 6, 2025
Merged

Do not rely on cv namespace in HAL#26878
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/respect_namespace_hal

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Feb 6, 2025

namespace cv should be used explicitly. Otherwise it causes build issues with several HALs enabled together.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: build/install category: 3rdparty platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Feb 6, 2025
@asmorkalov asmorkalov changed the title Do not rely on cv namespace in HAL. Do not rely on cv namespace in HAL Feb 6, 2025
@asmorkalov asmorkalov requested a review from mshabunin February 6, 2025 07:04
@asmorkalov asmorkalov added this to the 4.12.0 milestone Feb 6, 2025
@asmorkalov asmorkalov removed the request for review from mshabunin February 6, 2025 08:05
@asmorkalov asmorkalov self-assigned this Feb 6, 2025
@asmorkalov asmorkalov merged commit 9a566d7 into opencv:4.x Feb 6, 2025
27 of 28 checks passed
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build/install category: 3rdparty platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant