Skip to content

fix related the issue 22551#26851

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:fix-22551
Jan 29, 2025
Merged

fix related the issue 22551#26851
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:fix-22551

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

@sturkmen72 sturkmen72 commented Jan 27, 2025

related #22551
tEXt: chunk data size is being controlled by LibPNG

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from vrabaud January 28, 2025 04:28
@asmorkalov asmorkalov self-assigned this Jan 28, 2025
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 28, 2025

http://www.libpng.org/pub/png/spec/1.2/PNG-Chunks.html#C.tEXt:
The keyword and text string are separated by a zero byte (null character). Neither the keyword nor the text string can contain a null character. Note that the text string is not null-terminated (the length of the chunk is sufficient information to locate the ending). The text string can be of any length from zero bytes up to the maximum permissible chunk size less the length of the keyword and separator.

@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 28, 2025
vrabaud
vrabaud reviewed Jan 28, 2025
View reviewed changes
@asmorkalov asmorkalov merged commit d5f6930 into opencv:4.x Jan 29, 2025
@sturkmen72 sturkmen72 deleted the fix-22551 branch January 29, 2025 15:48
@warped-rudi
Copy link
Copy Markdown
Contributor

warped-rudi commented Jan 29, 2025

Are we supposed to support big-endian platforms? I'm asking because of the id_XXXX constants...

@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vrabaud vrabaud vrabaud left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: imgcodecs

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sturkmen72 @asmorkalov @warped-rudi @vrabaud