APNG encoding optimization by sturkmen72 · Pull Request #26849 · opencv/opencv

sturkmen72 · 2025-01-27T11:56:09Z

related #26840

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

modules/imgcodecs/src/grfmt_png.cpp

asmorkalov · 2025-01-27T14:14:57Z

I propose to add simple performance test.

vrabaud · 2025-01-27T15:28:01Z

An animation with 1 frame is not the same as one image (though it will be displayed the same).

sturkmen72 · 2025-01-27T15:41:17Z

An animation with 1 frame is not the same as one image (though it will be displayed the same).

It should be like that for webp and avif. But when an animated png saved with only one frame, the only thing that changes actually is being 10 times slower.

following code just writes IHDR and IDAT chunks like imwrite

    Mat m(2000,3000,CV_8UC4);
    Animation tanimation;
    tanimation.frames.push_back(m);
    tanimation.durations.push_back(10);

    imwriteanimation("read_c.png", tanimation);c

sturkmen72 · 2025-01-27T15:50:15Z

anyway let me work on this PR a bit more. creating a performans test and maybe rethinking on one frame apng

sturkmen72 · 2025-01-29T12:54:37Z

it was Z_BEST_COMPRESSION used for writing ( even writing with IMWRITE_PNG_COMPRESSION param)
now Z_BEST_SPEED ( 1 ) is default and IMWRITE_PNG_COMPRESSION param works

modules/imgcodecs/src/grfmt_png.cpp

asmorkalov · 2025-02-04T09:48:48Z

@sturkmen72 Please rebase and fix conflict after you PR merge.

modules/imgcodecs/src/grfmt_png.cpp

modules/imgcodecs/perf/perf_png.cpp

asmorkalov · 2025-02-20T10:29:20Z

modules/imgcodecs/perf/perf_png.cpp

+    SANITY_CHECK_NOTHING();
+}
+
+PERF_TEST_P(PNG, DISABLED_params_filter_max_compression, testing::ValuesIn(PNGFilterFlags))


Why is it disabled?

when a common user run it takes so long time ( --perf_force_samples default value is 100 )

asmorkalov · 2025-02-20T10:30:32Z

modules/imgcodecs/include/opencv2/imgcodecs.hpp

+       IMWRITE_PNG_NO_FILTERS            = 0,   //!< Disables all filtering. No filters will be applied when saving the image.
+       IMWRITE_PNG_FILTER_NONE           = 8,   //!< Applies no filter to the PNG image (useful when you want to save the raw pixel data without any compression filter).


What is difference between IMWRITE_PNG_NO_FILTERS and IMWRITE_PNG_FILTER_NONE? Why do we need both?

they produces different sized outputs

IMWRITE_PNG_NO_FILTERS removed. with libpng IMWRITE_PNG_NO_FILTERS and IMWRITE_PNG_ALL_FILTERS gives same results. with libspng IMWRITE_PNG_NO_FILTERS and IMWRITE_PNG_FILTER_NONE gives same results.

modules/imgcodecs/include/opencv2/imgcodecs.hpp

sturkmen72 · 2025-02-21T12:58:51Z

@asmorkalov i will try to write tests using PngSuite - Image filtering / PNG-files

asmorkalov · 2025-02-21T14:17:58Z

Ok, please try to use existing files in opencv-extra and do not add more. We have some subset of the suite already.

asmorkalov · 2025-02-25T12:47:49Z

@sturkmen72 Please rebase and fix conflicts.

asmorkalov · 2025-03-03T12:16:59Z

@vrabaud I'm ready to merge the patch. Do you have any remarks?

modules/imgcodecs/perf/perf_png.cpp

modules/imgcodecs/src/grfmt_spng.cpp

modules/imgcodecs/src/grfmt_spng.hpp

modules/imgcodecs/src/grfmt_png.cpp

asmorkalov · 2025-03-05T07:26:26Z

@vrabaud Please take a look again.

sturkmen72 commented Jan 27, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_png.cpp Outdated Show resolved Hide resolved

asmorkalov requested a review from vrabaud January 27, 2025 13:04

asmorkalov added the category: imgcodecs label Jan 27, 2025

sturkmen72 marked this pull request as draft January 27, 2025 22:43

asmorkalov changed the title ~~APNG - Use common write function when frames size < 2~~ APNG encoding optimization Jan 29, 2025

asmorkalov added this to the 4.12.0 milestone Jan 29, 2025

asmorkalov marked this pull request as ready for review January 29, 2025 13:00

asmorkalov self-requested a review January 29, 2025 13:00

vrabaud reviewed Jan 29, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_png.cpp Outdated Show resolved Hide resolved

sturkmen72 marked this pull request as draft January 31, 2025 08:52

sturkmen72 force-pushed the apng-writeanimation branch 3 times, most recently from 4cae20b to e70f4eb Compare February 4, 2025 08:39

sturkmen72 force-pushed the apng-writeanimation branch from e70f4eb to a22f8b5 Compare February 4, 2025 10:07

asmorkalov reviewed Feb 6, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_png.cpp Outdated Show resolved Hide resolved

asmorkalov reviewed Feb 6, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_png.cpp Outdated Show resolved Hide resolved

asmorkalov self-assigned this Feb 10, 2025

sturkmen72 force-pushed the apng-writeanimation branch from 943089c to 8e06f9d Compare February 10, 2025 20:53

sturkmen72 mentioned this pull request Feb 14, 2025

imread animation PNG writing speed performance is dramatically bad #26840

Closed

sturkmen72 force-pushed the apng-writeanimation branch from 7987be5 to 97004ac Compare February 19, 2025 19:04

sturkmen72 marked this pull request as ready for review February 19, 2025 19:51

sturkmen72 requested review from asmorkalov and vrabaud February 19, 2025 19:51

asmorkalov reviewed Feb 20, 2025

View reviewed changes

sturkmen72 force-pushed the apng-writeanimation branch 3 times, most recently from 22186b6 to cf59c0c Compare February 23, 2025 20:01

sturkmen72 force-pushed the apng-writeanimation branch 4 times, most recently from eda302f to e9f5c7e Compare February 25, 2025 13:28

APNG PNG Encoding Optimizations

8446122

sturkmen72 force-pushed the apng-writeanimation branch from e9f5c7e to 8446122 Compare February 25, 2025 13:36

sturkmen72 marked this pull request as ready for review March 1, 2025 11:57

sturkmen72 requested a review from asmorkalov March 1, 2025 11:57

sturkmen72 added 2 commits March 1, 2025 17:08

Update grfmt_png.cpp

d14b17c

Update grfmt_spng.cpp

ca96142

asmorkalov approved these changes Mar 3, 2025

View reviewed changes

sturkmen72 commented Mar 3, 2025

View reviewed changes

modules/imgcodecs/perf/perf_png.cpp Outdated Show resolved Hide resolved

Update perf_png.cpp

8047e71

asmorkalov added the feature label Mar 3, 2025

vrabaud reviewed Mar 3, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_spng.cpp Outdated Show resolved Hide resolved

vrabaud reviewed Mar 3, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_spng.hpp Outdated Show resolved Hide resolved

vrabaud reviewed Mar 3, 2025

View reviewed changes

modules/imgcodecs/src/grfmt_png.cpp Outdated Show resolved Hide resolved

sturkmen72 added 2 commits March 3, 2025 19:26

required changes

01b7b5e

Update grfmt_spng.hpp

ff7e98d

asmorkalov merged commit dbd4e45 into opencv:4.x Mar 5, 2025
28 checks passed

sturkmen72 deleted the apng-writeanimation branch March 5, 2025 08:18

asmorkalov mentioned this pull request Mar 11, 2025

5.x merge 4.x #27045

Merged

		IMWRITE_PNG_NO_FILTERS = 0, //!< Disables all filtering. No filters will be applied when saving the image.
		IMWRITE_PNG_FILTER_NONE = 8, //!< Applies no filter to the PNG image (useful when you want to save the raw pixel data without any compression filter).

Uh oh!

Conversation

sturkmen72 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

Uh oh!

asmorkalov commented Jan 27, 2025

Uh oh!

vrabaud commented Jan 27, 2025

Uh oh!

sturkmen72 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sturkmen72 commented Jan 27, 2025

Uh oh!

sturkmen72 commented Jan 29, 2025

Uh oh!

Uh oh!

asmorkalov commented Feb 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

sturkmen72 Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

asmorkalov Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

sturkmen72 Feb 20, 2025

Choose a reason for hiding this comment

Uh oh!

sturkmen72 Feb 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sturkmen72 commented Feb 21, 2025

Uh oh!

asmorkalov commented Feb 21, 2025

Uh oh!

asmorkalov commented Feb 25, 2025

Uh oh!

asmorkalov commented Mar 3, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asmorkalov commented Mar 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sturkmen72 commented Jan 27, 2025 •

edited

Loading

sturkmen72 commented Jan 27, 2025 •

edited

Loading