Skip to content

Fix bug different marker ordering with findChessboardCornersSBWithMeta and CALIB_CB_LARGER flag#26847

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
IHni3:4.x
Jan 27, 2025
Merged

Fix bug different marker ordering with findChessboardCornersSBWithMeta and CALIB_CB_LARGER flag#26847
asmorkalov merged 1 commit intoopencv:4.xfrom
IHni3:4.x

Conversation

@IHni3
Copy link
Copy Markdown

@IHni3 IHni3 commented Jan 27, 2025

Fix for proposed issue in #26830

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@IHni3 IHni3 changed the title fix bug different marker ordering with findChessboardCornersSBWithMeta and CALIB_CB_LARGER flag Fix bug different marker ordering with findChessboardCornersSBWithMeta and CALIB_CB_LARGER flag Jan 27, 2025
@IHni3 IHni3 mentioned this pull request Jan 27, 2025
Closed
4 tasks
@asmorkalov asmorkalov added category: calib3d pr: needs test New functionality requires minimal tests set labels Jan 27, 2025
@asmorkalov asmorkalov self-requested a review January 27, 2025 08:00
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jan 27, 2025

@IHni3 Could you add simple test for the case like in the ticket.

@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 27, 2025
@IHni3
Copy link
Copy Markdown
Author

IHni3 commented Jan 27, 2025 •
edited
Loading

@asmorkalov I just added a test.

@asmorkalov asmorkalov self-assigned this Jan 27, 2025
@asmorkalov asmorkalov removed the pr: needs test New functionality requires minimal tests set label Jan 27, 2025
@asmorkalov asmorkalov merged commit 4403e3b into opencv:4.x Jan 27, 2025
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: calib3d

Projects

None yet

Milestone

4.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@IHni3 @asmorkalov