Skip to content

Avoid adding value to nullptr#26769

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
y-guyon:patch-1
Jan 14, 2025
Merged

Avoid adding value to nullptr#26769
asmorkalov merged 1 commit intoopencv:4.xfrom
y-guyon:patch-1

Conversation

@y-guyon
Copy link
Copy Markdown
Contributor

@y-guyon y-guyon commented Jan 14, 2025

This undefined behavior can be avoided by postponing calculation until needed.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

This UB can be avoided by postponing calculation until needed.
@asmorkalov asmorkalov added this to the 4.12.0 milestone Jan 14, 2025
@asmorkalov asmorkalov self-requested a review January 14, 2025 13:22
@asmorkalov asmorkalov self-assigned this Jan 14, 2025
@asmorkalov asmorkalov merged commit 796adf5 into opencv:4.x Jan 14, 2025
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants