Skip to content

Fix tests for ellipse fitting#26716

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-tests-for-ellipse-fitting
Jan 6, 2025
Merged

Fix tests for ellipse fitting#26716
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:fix-tests-for-ellipse-fitting

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

Before comparison of ellipses was incomplete - only one point of test ellipse with index j = 1 was involved in inner loop (instead of all for complete comparison)

Related to #26694

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-requested a review January 6, 2025 07:56
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jan 6, 2025
@asmorkalov asmorkalov self-assigned this Jan 6, 2025
@asmorkalov asmorkalov merged commit 904dbe9 into opencv:4.x Jan 6, 2025
@MaximSmolskiy MaximSmolskiy deleted the fix-tests-for-ellipse-fitting branch January 6, 2025 11:33
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants