Skip to content

Animated GIF APNG WEBP AVIF revisions#26688

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:gif-png-webp-avif
Jan 4, 2025
Merged

Animated GIF APNG WEBP AVIF revisions#26688
asmorkalov merged 1 commit intoopencv:4.xfrom
sturkmen72:gif-png-webp-avif

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

related issues #24855

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.11.0 milestone Dec 30, 2024
@asmorkalov asmorkalov self-requested a review December 31, 2024 06:25
@asmorkalov asmorkalov self-assigned this Dec 31, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

@sturkmen72 Is the PR ready for merge?

@asmorkalov asmorkalov changed the title [WIP]Animated GIF APNG WEBP AVIF revisions Animated GIF APNG WEBP AVIF revisions Dec 31, 2024
@sturkmen72
Copy link
Copy Markdown
Contributor Author

@asmorkalov if you have time to release 4.11 please let me check again this PR until tomorrow.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

i did not test it with different gif files yet.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

about last commit : i corrected durations according the following info from ChatGPT
2. Delay Time Field
The Delay Time is stored in two bytes within the GCE block.
It represents the delay in hundredths of a second (1 unit = 10 milliseconds).
For example:
A delay value of 0x0064 means 100 (decimal), which equals 1 second.
A delay value of 0x000A means 10 (decimal), which equals 0.1 second.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

OK. thank you for your great support. i think the PR can be merged. Happy new year for All.

@sturkmen72
Copy link
Copy Markdown
Contributor Author

just remember OCV_OPTION(WITH_IMGCODEC_GIF "Include GIF support" ON for test purpose.

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Jan 2, 2025

Let get the following in order first:

@sturkmen72
Copy link
Copy Markdown
Contributor Author

@asmorkalov I rebased commits and force-pushed changes.

@vrabaud
Copy link
Copy Markdown
Contributor

vrabaud commented Jan 3, 2025

LGTM

@asmorkalov asmorkalov merged commit ff18c9c into opencv:4.x Jan 4, 2025
@sturkmen72 sturkmen72 deleted the gif-png-webp-avif branch January 4, 2025 15:35
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants