Fix null pointer dereference in Tracklet by initializing rgb_feature#26682
Merged
asmorkalov merged 5 commits intoopencv:4.xfrom Mar 31, 2025
Merged
Fix null pointer dereference in Tracklet by initializing rgb_feature#26682asmorkalov merged 5 commits intoopencv:4.xfrom
asmorkalov merged 5 commits intoopencv:4.xfrom
Conversation
…_, adding AddRgbFeature(), and improving robustness in ComputeRgbDistance().
Contributor
Author
|
I'm testing locally right now will be pushing it again as it's done |
AumGupta
approved these changes
Jan 7, 2025
asmorkalov
reviewed
Feb 7, 2025
modules/gapi/src/3rdparty/vasot/src/components/ot/test_tracklet.cpp
Outdated
Show resolved
Hide resolved
Contributor
|
@dmatveev @TolyaTalamanov Friendly reminder. |
Contributor
|
Thanks a lot @5usu ! I think @AsyaPronina is the right person to have a look here, I'll ask her to review the change. |
AsyaPronina
requested changes
Mar 26, 2025
modules/gapi/src/3rdparty/vasot/src/components/ot/mtt/objects_associator.cpp
Outdated
Show resolved
Hide resolved
modules/gapi/src/3rdparty/vasot/src/components/ot/test_tracklet.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@AsyaPronina done with the indentation and redundant file is removed |
AsyaPronina
approved these changes
Mar 28, 2025
Contributor
Author
|
so this going to be merged? |
This was referenced Apr 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding AddRgbFeature(), and improving robustness in ComputeRgbDistance().
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.