Remove useless -Wno-long-long option#26635
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 27, 2024
Merged
Conversation
According to GCC doc, -Wlong-long: Warn if long long type is used. This is enabled by either -Wpedantic or -Wtraditional in ISO C90 and C++98 modes. To inhibit the warning messages, use -Wno-long-long. OpenCV 4.x requires C++11. As result, this option is useless. Ref: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Contributor
|
@mshabunin could you take a look? |
Contributor
Author
|
I would like to add that |
mshabunin
approved these changes
Dec 18, 2024
Contributor
mshabunin
left a comment
There was a problem hiding this comment.
Let's merge it together with buildbot configuration update.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to GCC doc, -Wlong-long: Warn if long long type is used. This is enabled by either -Wpedantic or -Wtraditional in ISO C90 and C++98 modes. To inhibit the warning messages, use -Wno-long-long.
OpenCV 4.x requires C++11. As result, this option is useless.
Ref: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.