Skip to content

Update KleidiCV to version 0.3#26623

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/kelidicv_0.3
Dec 16, 2024
Merged

Update KleidiCV to version 0.3#26623
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/kelidicv_0.3

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Dec 13, 2024 •
edited
Loading

KleidiCV 0.3 release notes: https://gitlab.arm.com/kleidi/kleidicv/-/releases

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc category: 3rdparty labels Dec 13, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Dec 13, 2024
@asmorkalov asmorkalov force-pushed the as/kelidicv_0.3 branch 2 times, most recently from 1f8bff8 to f60629d Compare December 13, 2024 06:36
@asmorkalov asmorkalov changed the title Update KleidiCV to version 0.3. Update KleidiCV to version 0.3 Dec 13, 2024
opencv-alalek
opencv-alalek reviewed Dec 16, 2024
View reviewed changes
3rdparty/kleidicv/CMakeLists.txt
# HACK to suppress adapters/opencv/kleidicv_hal.cpp:343:12: warning: unused function 'from_opencv' [-Wunused-function]
target_compile_options( kleidicv_hal PRIVATE
$<TARGET_PROPERTY:kleidicv,COMPILE_OPTIONS>
"-Wno-old-style-cast" "-Wno-unused-function"
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to include through -isystem to avoid warnings from these external headers.

https://gcc.gnu.org/onlinedocs/gcc/Directory-Options.html
https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html

Example:
https://github.com/opencv/opencv/blob/4.10.0/3rdparty/protobuf/CMakeLists.txt#L154

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Dec 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue happens inside cpp file, not header. So the -isystem flag is not applicable here.

Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this widely used approach not work?

https://github.com/opencv/opencv/blob/4.10.0/3rdparty/libjpeg-turbo/CMakeLists.txt#L11

Copy link
Copy Markdown
Contributor Author

@asmorkalov asmorkalov Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it. Most probably the issue is that the ocv_disable_warning works well inside the cmake "project" scope, but does not outside.

@asmorkalov asmorkalov self-assigned this Dec 16, 2024
@asmorkalov asmorkalov merged commit 1a1b190 into opencv:4.x Dec 16, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

Assignees

@asmorkalov asmorkalov

Labels

category: 3rdparty optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @opencv-alalek