objdetect: fix invalid vector access in QR de/encoder#26532
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Nov 29, 2024
Merged
objdetect: fix invalid vector access in QR de/encoder#26532asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
dkurt
approved these changes
Nov 26, 2024
Member
dkurt
left a comment
There was a problem hiding this comment.
Can we merge as a workaround for now and I can check the test precisely later?
9f3c793 to
e953fcf
Compare
asmorkalov
approved these changes
Nov 29, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be cases when more bits are requested than available in the bitstream.
Partial stacktrace:
I'm not sure if we should fix decode process or just ignore extra bits which do not fit the bitstream. We can print some message to the log, but currently it is disabled.cc @dkurt
Two changes in this PR:
whileloop and soft check in the last bits processing.writeDecNumberhas been used to append zero values to vector, in some cases it caused too large bit-shifts (>32bit). We replaced several such cases with explicit zero insertion.