Document some stitching methods and enable bindings for them.#26516
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Nov 28, 2024
Merged
Document some stitching methods and enable bindings for them.#26516asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
mshabunin
reviewed
Nov 26, 2024
|
|
||
| /** Returns estimated camera parameters for all stitched images | ||
| */ | ||
| CV_WRAP std::vector<cv::detail::CameraParams> cameras() const { return cameras_; } |
Contributor
There was a problem hiding this comment.
As I can see setTransform method is not wrapped, it seems that is not possible to set cameras_ from Python.
Contributor
Author
There was a problem hiding this comment.
There is issue in current generator implementation:
In file included from /mnt/Projects/Projects/opencv/modules/python/src2/cv2.cpp:88:
/mnt/Projects/Projects/opencv-build/modules/python_bindings_generator/pyopencv_generated_types_content.h: In function ‘PyObject* pyopencv_cv_Stitcher_setTransform(PyObject*, PyObject*, PyObject*)’:
/mnt/Projects/Projects/opencv-build/modules/python_bindings_generator/pyopencv_generated_types_content.h:21351:5: error: ‘vector_detail_CameraParams’ was not declared in this scope; did you mean ‘vector_CameraParams’?
21351 | vector_detail_CameraParams cameras;
Let's handle it separately.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.