Skip to content

Disable SME2 branches in KleidiCV as it's incompatible with some CLang versions, e.g. NDK 28b1#26390

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/kleidicv_no_sme2
Oct 31, 2024
Merged

Disable SME2 branches in KleidiCV as it's incompatible with some CLang versions, e.g. NDK 28b1#26390
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/kleidicv_no_sme2

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: build/install platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Oct 31, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Oct 31, 2024
@asmorkalov asmorkalov merged commit ddc03c0 into opencv:4.x Oct 31, 2024
@asmorkalov asmorkalov self-assigned this Oct 31, 2024
set(THE_ROOT "${OpenCV_BINARY_DIR}/3rdparty/kleidicv/kleidicv-${KLEIDICV_SRC_COMMIT}")
endif()

option(KLEIDICV_ENABLE_SME2 "" OFF) # not compatible with some CLang versions in NDK
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(ANDRROID) ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not specific to Android, it's clang side effect.

@asmorkalov asmorkalov mentioned this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants