Skip to content

C++26 Deprecated Enum Arithmetic Conversion: Fix core/mat.inl.hpp#26284

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
fzuuzf:enum_arithmetic_fixes_for_c++26
Oct 21, 2024
Merged

C++26 Deprecated Enum Arithmetic Conversion: Fix core/mat.inl.hpp#26284
asmorkalov merged 1 commit intoopencv:4.xfrom
fzuuzf:enum_arithmetic_fixes_for_c++26

Conversation

@fzuuzf
Copy link
Copy Markdown

@fzuuzf fzuuzf commented Oct 10, 2024

Prefix enums with '+' to make clang c++26 add to them again.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

C++26 Deprecated Arithmetic Conversion: Fix core/mat.inl.hpp
2a681bb 
Prefix enums with '+' to make clang c++26 add to them again.
@fzuuzf fzuuzf changed the title C++26 Deprecated Arithmetic Conversion: Fix core/mat.inl.hpp C++26 Deprecated Enum Arithmetic Conversion: Fix core/mat.inl.hpp Oct 10, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Oct 10, 2024

C++26 is not ready yet. I propose to not harry with the changes.

@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Oct 18, 2024

@fzuuzf, question to you: does your patch solves OpenCV compilation issues with C++ 26? Or your patch is just beginning of the effort?

@fzuuzf
Copy link
Copy Markdown
Author

fzuuzf commented Oct 19, 2024 •
edited
Loading

@vpisarev: Yes, it solves compiling a project with clang trunk here.

@asmorkalov asmorkalov self-requested a review October 21, 2024 12:21
@asmorkalov asmorkalov added this to the 4.11.0 milestone Oct 21, 2024
@asmorkalov asmorkalov self-assigned this Oct 21, 2024
@asmorkalov asmorkalov merged commit 94d5ad0 into opencv:4.x Oct 21, 2024
@asmorkalov asmorkalov mentioned this pull request Oct 23, 2024
Merged
@asmorkalov asmorkalov mentioned this pull request Nov 25, 2024
Closed
4 tasks
@calcmogul calcmogul mentioned this pull request Dec 7, 2024
Closed
@asmorkalov asmorkalov mentioned this pull request Dec 9, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: core

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fzuuzf @asmorkalov @vpisarev