Skip to content

OpenCL-OpenGL interop support for apple#26274

Closed
kallaballa wants to merge 4 commits intoopencv:4.xfrom
kallaballa:clgl_apple_support
Closed

OpenCL-OpenGL interop support for apple#26274
kallaballa wants to merge 4 commits intoopencv:4.xfrom
kallaballa:clgl_apple_support

Conversation

@kallaballa
Copy link
Copy Markdown
Contributor

@kallaballa kallaballa commented Oct 9, 2024

WIP

Experimental support for cl_APPLE_gl_sharing. Issue: #26273

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@kallaballa
Copy link
Copy Markdown
Contributor Author

kallaballa commented Oct 9, 2024

Would you please bump a Mac build?

@asmorkalov asmorkalov added this to the 4.11.0 milestone Oct 9, 2024
@asmorkalov asmorkalov self-requested a review October 9, 2024 06:11
opencv-alalek
opencv-alalek reviewed Oct 9, 2024
View reviewed changes
modules/core/src/opengl.cpp Outdated
#elif defined(__ANDROID__)
#elif defined (__APPLE__)
CL_CONTEXT_PROPERTY_USE_CGL_SHAREGROUP_APPLE, (cl_context_properties)cglShareGroup,
#elif defined(__ANDROID__) || defined(MACOSX)
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asmorkalov Why Android?

Copy link
Copy Markdown
Contributor Author

@kallaballa kallaballa Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kallaballa kallaballa mentioned this pull request Oct 9, 2024
Merged
6 tasks
@kallaballa
Copy link
Copy Markdown
Contributor Author

kallaballa commented Oct 9, 2024

This PR is not satisfactory since it will never work on all required platforms.
Closed in favor of: #26281

@kallaballa kallaballa closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees

No one assigned

Labels

category: core category: highgui-gui platform: ios/osx

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kallaballa @opencv-alalek @asmorkalov