Skip to content

SQPnP solver updates#26219

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
mlourakis:4.x
Oct 1, 2024
Merged

SQPnP solver updates#26219
asmorkalov merged 1 commit intoopencv:4.xfrom
mlourakis:4.x

Conversation

@mlourakis
Copy link
Copy Markdown
Contributor

Mirror most recent changes from terzakig/sqpnp#24

  • rank revealing QR in nullspace computation
  • sqrt-free Cholesky (i.e., LDLt) in the SQP solution
  • replaced divisions with multiplications by inverses
  • simplified checks in computeRowAndNullspace()
  • removed unnecessary negations
  • broke some dependency chains with parentheses
  • minor other changes

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Mirror most recent changes from terzakig/sqpnp#24
  - rank revealing QR in nullspace computation
  - sqrt-free Cholesky (i.e., L*D*Lt) in the SQP solution
  - replaced divisions with multiplications by inverses
  - simplified checks in computeRowAndNullspace()
  - removed unnecessary negations
  - broke some dependency chains with parentheses
  - minor other changes
@asmorkalov asmorkalov added this to the 4.11.0 milestone Oct 1, 2024
@asmorkalov asmorkalov requested a review from vpisarev October 1, 2024 04:58
@asmorkalov asmorkalov merged commit 658336b into opencv:4.x Oct 1, 2024
@asmorkalov asmorkalov mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants