Skip to content

Got rid of CAROTENE_NEON_ARCH and use standard __ARM_ARCH check#26091

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/arm_version_check
Sep 2, 2024
Merged

Got rid of CAROTENE_NEON_ARCH and use standard __ARM_ARCH check#26091
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/arm_version_check

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Aug 30, 2024

Manual CAROTENE_NEON_ARCH was introduced in #24271.
__ARM_ARCH marco is standard way and do not require extra options on user side:

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@fengyuentau fengyuentau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We can promote this in intrin_neon.hpp

@opencv-alalek opencv-alalek added optimization platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc labels Aug 30, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor Author

cc @vpisarev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants