speedup random forest getVotes method.#26046
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Aug 20, 2024
ivafanas:speedup_random_forest_get_votes
Merged
speedup random forest getVotes method.#26046asmorkalov merged 1 commit intoopencv:4.xfrom ivafanas:speedup_random_forest_get_votes
asmorkalov merged 1 commit intoopencv:4.xfrom
ivafanas:speedup_random_forest_get_votes
Conversation
Contributor
|
The classic ml module was moved to opencv_contrib repo in 5.x branch. It means that the optimization will not be promoted to 5.x automatically. Could @ivafanas could you create yet another PR there. See https://github.com/opencv/opencv_contrib/blob/5.x/modules/ml/src/rtrees.cpp |
Author
|
Nice, I'll do that. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speedup
DTreesImplForRTrees::getVotesmethod in about x2 times.Matobjects are usually not expensive for creation or copying. But if algorithm itself is fast, operations onMatobjects start to take significant time. Naive extraction of loop invariant temporaryMatwrapper object creation allows to decreasegetVotesmethod run time in about x2 times.