Docfix - Remove notice on using deprecated itemset#26041
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Aug 19, 2024
knmcguire:patch-1
Merged
Docfix - Remove notice on using deprecated itemset#26041asmorkalov merged 1 commit intoopencv:4.xfrom knmcguire:patch-1
asmorkalov merged 1 commit intoopencv:4.xfrom
knmcguire:patch-1
Conversation
asmorkalov
approved these changes
Aug 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #26035
The tutorial of basic image operations https://docs.opencv.org/4.10.0/d3/df2/tutorial_py_basic_ops.html is still recommending using itemset. However this is now a deprecated functionality in Numpy 2.+ and in 1.+ there is a deprecation warning (or at least that is what they say).
We can still keep the warning about single pixel accessing as in the big picture that is still valid to not encourage people to access single pixels like this, but .itemset ain't a good option anymore.
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.