Skip to content

Workaround for division by zero, issue #25795#26030

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
CNClareChen:4.x
Aug 30, 2024
Merged

Workaround for division by zero, issue #25795#26030
asmorkalov merged 1 commit intoopencv:4.xfrom
CNClareChen:4.x

Conversation

@CNClareChen
Copy link
Copy Markdown
Contributor

@CNClareChen CNClareChen commented Aug 15, 2024 •
edited by asmorkalov
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Workaround the #25795 Issue by adopting the solution from #21044 issue.
Relates #20914

@asmorkalov asmorkalov requested review from TolyaTalamanov and dmatveev and removed request for asmorkalov and vpisarev August 19, 2024 12:42
@asmorkalov asmorkalov added category: g-api / gapi platform: loongson Loonson CPU architecure and LASX simd labels Aug 19, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Aug 19, 2024
@CNClareChen
Reinitialize divider matrix in DivRCPerfTest and DivPerfTest Cases.
9c19a0c 
This patch reinitializes divider matrix without zero values in DivRCPerfTest
and DivPerfTest test cases.
@asmorkalov asmorkalov changed the title Resolve #25795 Issue Workaround for division by zero, issue #25795 Aug 30, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Aug 30, 2024

The workaround was discussed and approved by the Core Team.

@asmorkalov asmorkalov self-assigned this Aug 30, 2024
@asmorkalov asmorkalov added test and removed RFC labels Aug 30, 2024
@asmorkalov asmorkalov merged commit 2829a6d into opencv:4.x Aug 30, 2024
@asmorkalov asmorkalov mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@fengyuentau fengyuentau Awaiting requested review from fengyuentau

@dmatveev dmatveev Awaiting requested review from dmatveev

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

Assignees

@asmorkalov asmorkalov

Labels

category: g-api / gapi platform: loongson Loonson CPU architecure and LASX simd test

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@CNClareChen @asmorkalov @fengyuentau