Skip to content

Fix path to 3rdparty cmake.#25983

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
stepkareserva:4.x
Aug 2, 2024
Merged

Fix path to 3rdparty cmake.#25983
asmorkalov merged 1 commit intoopencv:4.xfrom
stepkareserva:4.x

Conversation

@stepkareserva
Copy link
Copy Markdown
Contributor

@stepkareserva stepkareserva commented Aug 2, 2024

Current code using CMAKE_SOURCE_DIR and it works well if opencv is standalone CMake project, but in case of building OpenCV as part of a larger CMake project (e.g. one that includes opencv and opencv_contrib) this path is incorrect, unlike OpenCV_SOURCE_DIR

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Current code using CMAKE_SOURCE_DIR and it works well if opencv is standalone CMake project,
but in case of building OpenCV as part of a larger CMake project (e.g. one that includes
opencv and opencv_contrib) this path is incorrect, unlike OpenCV_SOURCE_DIR
@asmorkalov asmorkalov added this to the 4.11.0 milestone Aug 2, 2024
@asmorkalov asmorkalov merged commit 95041f5 into opencv:4.x Aug 2, 2024
@asmorkalov asmorkalov mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants