Skip to content

highgui: Make GThread mandatory with GTK#25905

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
tintou:tintou/glib-cleanup
Jul 19, 2024
Merged

highgui: Make GThread mandatory with GTK#25905
asmorkalov merged 1 commit intoopencv:4.xfrom
tintou:tintou/glib-cleanup

Conversation

@tintou
Copy link
Copy Markdown
Contributor

@tintou tintou commented Jul 13, 2024

The GThread API is available since more than 11 years with GLib, it is now safe to assume that it is always available.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@tintou tintou changed the base branch from master to 4.x July 13, 2024 10:46
@asmorkalov asmorkalov requested a review from opencv-alalek July 15, 2024 06:27
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 15, 2024

Even in Ubuntu 12.04 GThread is part of libglib package. So the cleanup makes sense. Could you push empty commit to re-trigger CI?

@asmorkalov asmorkalov added category: highgui-gui category: build/install cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Jul 15, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 15, 2024
@tintou tintou force-pushed the tintou/glib-cleanup branch from 85f0de6 to ecb6eb4 Compare July 15, 2024 08:44
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 15, 2024

@tintou Please rebase and fix conflicts. I merged older PR for OpenGL support with GTK3. Sorry for often pushes.

@asmorkalov asmorkalov self-requested a review July 15, 2024 14:11
@tintou tintou force-pushed the tintou/glib-cleanup branch from ecb6eb4 to 5990671 Compare July 15, 2024 14:18
@tintou
Copy link
Copy Markdown
Contributor Author

tintou commented Jul 15, 2024

@asmorkalov done, no worries 🙂

@tintou
highgui: Make GThread mandatory with GTK
da078c4 
The GThread API is available since more than 11 years with GLib, it is now safe
to assume that it is always available.
@tintou tintou force-pushed the tintou/glib-cleanup branch from 5990671 to da078c4 Compare July 15, 2024 14:30
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 16, 2024

@opencv-alalek Please update hooks:

CMake Warning at /build/precommit_linux64/ci/cmake_checks/cmake_checks.cmake:105 (message):
  Manual validation is requied.  Variable is not defined: HAVE_GTHREAD
Call Stack (most recent call first):
  /build/precommit_linux64/ci/cmake_checks/precommit_linux64/POST_FINALIZE.cmake:94 (build_validate_enabled_flag)
  cmake/OpenCVUtils.cmake:65 (include)
  CMakeLists.txt:2007 (ocv_cmake_hook)

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Jul 19, 2024

Relaxed CI validation checks.

@opencv-alalek opencv-alalek removed their request for review July 19, 2024 10:59
@asmorkalov asmorkalov merged commit 26714f9 into opencv:4.x Jul 19, 2024
@asmorkalov asmorkalov self-assigned this Jul 19, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: highgui-gui cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tintou @asmorkalov @opencv-alalek