Skip to content

core: hal: avoid to use _tzcnt_u32 for ARM64EC#25903

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fixC3767
Jul 15, 2024
Merged

core: hal: avoid to use _tzcnt_u32 for ARM64EC#25903
asmorkalov merged 1 commit intoopencv:4.xfrom
Kumataro:fixC3767

Conversation

@Kumataro
Copy link
Copy Markdown
Contributor

@Kumataro Kumataro commented Jul 13, 2024

_tzcnt_u32 is not supported for ARM64EC, so avoid to use it.

Close opencv/opencv_contrib#3767

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Jul 13, 2024

CI test for this pull request is failed, but it may not be related this changed.

Test report said "GaussianBlur ( InputArray src, OutputArray dst, Size ksize, double sigmaX, double sigmaY, int borderType )" is removed. But This function's argument is changed by #25792 .

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Jul 13, 2024

CI test for this pull request is failed, but it may not be related this changed.

Definitely not related. Please ignore.
Mentioned PR has been merged against the RED CI checks, again.

I'm traveling without laptop on this weekend, so I will repair that only on Monday.

@Kumataro Kumataro marked this pull request as ready for review July 13, 2024 10:32
@Kumataro
Copy link
Copy Markdown
Contributor Author

Kumataro commented Jul 13, 2024

Thank you for your reply ! There are no problem.
This patch has been confirmed to be solved by the reporter, so the draft tag has been removed.

And we may be able to build for ARM64EC with disabling SSE3, SSE4, and other SIMD options for x86-64.
It seems that OpenCV should be update some using "_M_ARM64" to support "_M_ARM64EC" too.
But I have no ARM windows PC, so I cannot test it, so it is hard to fix it for me completly...

@asmorkalov asmorkalov added platform: win32 platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc and removed platform: other labels Jul 14, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 14, 2024
@asmorkalov asmorkalov self-requested a review July 14, 2024 08:20
@asmorkalov asmorkalov self-assigned this Jul 14, 2024
asmorkalov
asmorkalov approved these changes Jul 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the patch!

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 15, 2024

It seems that OpenCV should be update some using "_M_ARM64" to support "_M_ARM64EC" too.
But I have no ARM windows PC, so I cannot test it, so it is hard to fix it for me completly...

Unfortunately, we do not have it too.

@asmorkalov asmorkalov merged commit 81f3310 into opencv:4.x Jul 15, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
Merged
@shijunz
Copy link
Copy Markdown

shijunz commented Jan 9, 2025

It seems that OpenCV should be update some using "_M_ARM64" to support "_M_ARM64EC" too.
But I have no ARM windows PC, so I cannot test it, so it is hard to fix it for me completly...

Unfortunately, we do not have it too.
Thanks. I have ARM windows PC, I build it into arm64ec and run • ./opencv_test_core ./opencv_perf_core, pass most of test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install platform: arm ARM boards related issues: RPi, NVIDIA TK/TX, etc platform: win32

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

opencv_rgbd - Windows ARM64 / ARM64EC - Build issue - 4.10.0

4 participants

@Kumataro @opencv-alalek @asmorkalov @shijunz