Skip to content

core: add v_erf#25872

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
fengyuentau:core/v_erf
Jul 5, 2024
Merged

core: add v_erf#25872
asmorkalov merged 3 commits intoopencv:4.xfrom
fengyuentau:core/v_erf

Conversation

@fengyuentau
Copy link
Copy Markdown
Member

@fengyuentau fengyuentau commented Jul 5, 2024

This patch adds v_erf, which is needed by #25147.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Linux AVX2

@fengyuentau fengyuentau added this to the 4.11.0 milestone Jul 5, 2024
@fengyuentau fengyuentau mentioned this pull request Jul 5, 2024
Merged
6 tasks
@fengyuentau
Copy link
Copy Markdown
Member Author

fengyuentau commented Jul 5, 2024

There is one small problem. There are several coefficients that are also needed by non-vetorized version. Do they need to be shared across core and dnn module? Or we just keep two copies of them in different files.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 5, 2024

I propose to make copies and in vectorized version put reference to the flat origin.

fengyuentau
fengyuentau commented Jul 5, 2024
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 5, 2024 

modules/core/include/opencv2/core/hal/intrin_cpp.hpp:767: trailing whitespace.

@asmorkalov asmorkalov merged commit d30b945 into opencv:4.x Jul 5, 2024
@fengyuentau fengyuentau deleted the core/v_erf branch July 6, 2024 15:41
@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented Jul 8, 2024

There is regression detected by weekly build: https://pullrequest.opencv.org/buildbot/builders/4_x_noICV-win32-vc14/builds/100083

@opencv-alalek opencv-alalek removed their request for review July 8, 2024 07:48
@fengyuentau fengyuentau mentioned this pull request Jul 10, 2024
Merged
6 tasks
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
Merged
@WanliZhong WanliZhong mentioned this pull request Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

No one assigned

Labels

category: core optimization

Projects

OpenCV 5.0
Status: Done

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@fengyuentau @asmorkalov @opencv-alalek