Skip to content

Hacked gtkglext search in cmake#25865

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/gtk_2_opengl_fix
Jul 4, 2024
Merged

Hacked gtkglext search in cmake#25865
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/gtk_2_opengl_fix

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jul 3, 2024 •
edited
Loading

Fixes #20850

Error message on Ubuntu 18.04:

-- Configuring done
CMake Error in modules/highgui/CMakeLists.txt:
 Imported target "ocv.3rdparty.gtkglext" includes non-existent path 

 "/usr/lib/x86_64-linux-gnu/gtkglext-1.0/include" 

 in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include: 

 * The path was deleted, renamed, or moved to another location. 

 * An install or uninstall procedure did not complete successfully. 

 * The installation package was faulty and references files it does not 
 provide. 



CMake Error in modules/highgui/CMakeLists.txt:
 Imported target "ocv.3rdparty.gtkglext" includes non-existent path 

 "/usr/lib/x86_64-linux-gnu/gtkglext-1.0/include" 

 in its INTERFACE_INCLUDE_DIRECTORIES. Possible reasons include: 

 * The path was deleted, renamed, or moved to another location. 

 * An install or uninstall procedure did not complete successfully. 

 * The installation package was faulty and references files it does not 
 provide. 



-- Generating done

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 3, 2024
@asmorkalov asmorkalov changed the title Fixed gtkglext search in cmake Hacked gtkglext search in cmake Jul 4, 2024
mshabunin
mshabunin approved these changes Jul 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Perhaps we should move this postprocessing to ocv_check_modules macro. It already checks libraries existence and emits warning in case of error.

@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jul 4, 2024

The issue looks like Linux distro package bug rather then regular behavior. I prefer to introduce local hack then.

@asmorkalov asmorkalov merged commit 9f5139b into opencv:4.x Jul 4, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mshabunin mshabunin mshabunin approved these changes

@opencv-alalek opencv-alalek Awaiting requested review from opencv-alalek

Assignees

@mshabunin mshabunin

Labels

category: highgui-gui

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

highgui GTK2 with OpenGL broken in master

2 participants

@asmorkalov @mshabunin