imgproc: remove C-API usage from tests#25842
Merged
asmorkalov merged 3 commits intoopencv:4.xfrom Jul 4, 2024
Merged
Conversation
Contributor
|
asmorkalov
reviewed
Jul 3, 2024
|
|
||
| void CV_ColorBayerTest::run_func() | ||
| { | ||
| if(!test_cpp) |
Contributor
There was a problem hiding this comment.
The flag may be removed then.
|
|
||
| void CV_GetRectSubPixTest::run_func() | ||
| { | ||
| if(!test_cpp) |
Contributor
There was a problem hiding this comment.
test_cpp could be removed then
Comment on lines
+682
to
+691
| Mat pt = f0 + f1 * sin(i) + f2 * cos(i); | ||
| pt = pt.reshape(2); | ||
| pt.convertTo(points.row(i), CV_32SC2, int_scale); | ||
| } | ||
| else if (data_type == CV_32FC2) | ||
| { | ||
| Mat pt = f0 + f1 * sin(i) + f2 * cos(i); | ||
| pt = pt.reshape(2); | ||
| pt.copyTo(points.row(i)); | ||
| } |
Contributor
There was a problem hiding this comment.
The branches are the same besides convertTo/copyTo. Let's extract common part.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final cleanup will be done in 5.x after regular merge.
Some tests have been reworked, some required only slight modifications.