Skip to content

Extending G-API onnx::Params to pass arbitrary session options#25791

Merged
asmorkalov merged 8 commits intoopencv:4.xfrom
ujjayant-kadian:uk/extend-gapi-onnx-params-arbitrary-session-options
Jun 21, 2024
Merged

Extending G-API onnx::Params to pass arbitrary session options#25791
asmorkalov merged 8 commits intoopencv:4.xfrom
ujjayant-kadian:uk/extend-gapi-onnx-params-arbitrary-session-options

Conversation

@ujjayant-kadian
Copy link
Copy Markdown
Contributor

@ujjayant-kadian ujjayant-kadian commented Jun 20, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

TolyaTalamanov
TolyaTalamanov reviewed Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks, only minor comments 👍

@ujjayant-kadian
Copy link
Copy Markdown
Contributor Author

ujjayant-kadian commented Jun 20, 2024

I am correcting the build error right now.

TolyaTalamanov
TolyaTalamanov approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thank you! 👍

modules/gapi/include/opencv2/gapi/infer/onnx.hpp
*/
Params(const std::string& tag, const std::string& model_path)
: desc{model_path, 0u, 0u, {}, {}, {}, {}, {}, {}, {}, {}, {}, true, {}, {}, {}, false }, m_tag(tag) {}
: desc{model_path, 0u, 0u, {}, {}, {}, {}, {}, {}, {}, {}, {}, true, {}, {}, {}, {}, false}, m_tag(tag) {}
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚋🚋🚋

TolyaTalamanov
TolyaTalamanov requested changes Jun 20, 2024
View reviewed changes
@dmatveev dmatveev self-assigned this Jun 20, 2024
@dmatveev dmatveev added this to the 4.11.0 milestone Jun 20, 2024
dmatveev
dmatveev approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍approved, thanks!

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

TolyaTalamanov commented Jun 20, 2024

@asmorkalov can we merge it, please?

@asmorkalov asmorkalov merged commit 5dc1b39 into opencv:4.x Jun 21, 2024
@ujjayant-kadian ujjayant-kadian deleted the uk/extend-gapi-onnx-params-arbitrary-session-options branch June 21, 2024 13:49
@asmorkalov asmorkalov mentioned this pull request Jul 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@ujjayant-kadian @TolyaTalamanov @dmatveev @asmorkalov