Skip to content

fixed marker generation in charuco board#25673

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
AleksandrPanov:fix_charuco_board_markers
May 31, 2024
Merged

fixed marker generation in charuco board#25673
asmorkalov merged 2 commits intoopencv:4.xfrom
AleksandrPanov:fix_charuco_board_markers

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented May 30, 2024

When generating Charuco board markers in generateImage(), a problem occurs as in #24806, #24873:

In low resolution:
charucoImg_before_fix2
In medium resolution:
charucoImg_before_fix

This PR fixed this problems:
charucoImg_after_fix2
charucoImg_after_fix

The test checks the inner and outer borders of the Aruco markers. In the outer border of Aruco marker, all pixels should be white. In the inner border of Aruco marker, all pixels should be black.
image

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov added bug category: objdetect pr: needs test New functionality requires minimal tests set labels May 30, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone May 30, 2024
@asmorkalov asmorkalov self-requested a review May 30, 2024 09:56
@AleksandrPanov AleksandrPanov added test and removed pr: needs test New functionality requires minimal tests set labels May 30, 2024
@AleksandrPanov AleksandrPanov marked this pull request as ready for review May 30, 2024 22:00
@AleksandrPanov AleksandrPanov force-pushed the fix_charuco_board_markers branch from 4059ec9 to 267bd62 Compare May 31, 2024 06:38
@asmorkalov asmorkalov self-assigned this May 31, 2024
@AleksandrPanov AleksandrPanov force-pushed the fix_charuco_board_markers branch from 267bd62 to 3cb6766 Compare May 31, 2024 08:13
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 472eba3 into opencv:4.x May 31, 2024
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants