Skip to content

replace lena.jpg in find-existing-file tests#25643

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
cpoerschke:issue-25635-find-existing-file-tests
Aug 5, 2024
Merged

replace lena.jpg in find-existing-file tests#25643
asmorkalov merged 1 commit intoopencv:4.xfrom
cpoerschke:issue-25635-find-existing-file-tests

Conversation

@cpoerschke
Copy link
Copy Markdown
Contributor

similar to #25635 issue.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cpoerschke cpoerschke marked this pull request as ready for review May 25, 2024 08:16
@dkurt
Copy link
Copy Markdown
Member

dkurt commented May 25, 2024

Can you expand PR with more tests where it's possible? https://github.com/search?q=repo%3Aopencv%2Fopencv+lena.+path%3A%2F%5E*%5C%2Ftest%5C%2F%2F&type=code&p=1

@dkurt
Copy link
Copy Markdown
Member

dkurt commented May 25, 2024

No need for new data files while there is a bunch of existing ones: https://github.com/opencv/opencv_extra/tree/4.x/testdata

@asmorkalov asmorkalov self-requested a review August 5, 2024 12:27
@asmorkalov asmorkalov added this to the 4.11.0 milestone Aug 5, 2024
@asmorkalov asmorkalov added the test label Aug 5, 2024
@asmorkalov asmorkalov merged commit ea2a3cb into opencv:4.x Aug 5, 2024
@asmorkalov asmorkalov mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants