Replace static numpy allocator by function containing static.#25493
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Apr 27, 2024
Merged
Replace static numpy allocator by function containing static.#25493asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
That enables the numpy code to be its own library, in case some users want to (e.g. CLIF library).
VadimLevin
approved these changes
Apr 27, 2024
| }; | ||
|
|
||
| extern NumpyAllocator g_numpyAllocator; | ||
| inline NumpyAllocator& GetNumpyAllocator() {static NumpyAllocator gNumpyAllocator;return gNumpyAllocator;} |
Contributor
There was a problem hiding this comment.
Why is implementation here and not in .cpp file?
Not sure if we want multiple instances of this object.
GetNumpyAllocator
OpenCV function names start with lowercase.
Contributor
There was a problem hiding this comment.
There won't be multiple allocator instances, because function is not marked as static, so linker should strip its all internal static variables to 1
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no bug with the current implementation.
But this change enables the numpy code to be its own library, in case some users want to (e.g. CLIF library) and have the Python wrapper link to it. It would not be possible without this change as there would be a static initialization order fiasco otherwise.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request