Skip to content

Added moments interface to HAL.#25490

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_moments
Apr 26, 2024
Merged

Added moments interface to HAL.#25490
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_moments

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 25, 2024 •
edited
Loading

Address: #25489

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 25, 2024
vpisarev
vpisarev reviewed Apr 25, 2024
View reviewed changes
vpisarev
vpisarev reviewed Apr 25, 2024
View reviewed changes
vpisarev
vpisarev reviewed Apr 25, 2024
View reviewed changes
@vpisarev vpisarev self-requested a review April 25, 2024 14:29
@asmorkalov asmorkalov merged commit 2cd3304 into opencv:4.x Apr 26, 2024
@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Apr 27, 2024

const uchar* src_data

It reminds me that ILP64 has been supported in various BLAS library, such as OpenBLAS, Apple Accelerate. The input data type of source data, dimensions could be std::complex<float> and long instead of float and int, causing incompatibility of our hal interface to ILP64. Using uchar such data type can make hal compatible.

@asmorkalov asmorkalov mentioned this pull request May 3, 2024
Merged
6 tasks
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev approved these changes

@opencv-alalek opencv-alalek Awaiting requested review from opencv-alalek

Assignees

No one assigned

Labels

category: imgproc

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @fengyuentau @vpisarev