Skip to content

Comments for parser denylist#25465

Merged
asmorkalov merged 3 commits intoopencv:5.xfrom
Abdurrahheem:ash/parser-conf-denylist-reduce
Apr 22, 2024
Merged

Comments for parser denylist#25465
asmorkalov merged 3 commits intoopencv:5.xfrom
Abdurrahheem:ash/parser-conf-denylist-reduce

Conversation

@Abdurrahheem
Copy link
Copy Markdown
Contributor

@Abdurrahheem Abdurrahheem commented Apr 20, 2024

Relates to #21078

This PR is designed to figure out why the test in test_onnx_conformance_layer_parser_denylist.inl.hpp fails. Currently, conformance tests do not pass for the following reasons:

  1. BOOL, INT(8, 16) types are not supported (MAJOR)
  2. Some layers can not be created due to various reasons (MAJOR)
  3. Shape mismatches while creating layers (MAJOR)
  4. Some layers are expected to support dynamic parameter initialization (MAJOR)
  5. Some layers are expected to receive weight as inputs (no idea why that is needed) (MAJOR)
  6. Other unknown reasons

(MAJOR) - These are the most frequently encountered reasons for test failure.

The style of comments is not consistent everywhere. Let's keep this PR without merging, just for our reference.
A couple of tests are commented on since they have passed on the MacOS platform.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@Abdurrahheem Abdurrahheem added this to the 5.0 milestone Apr 20, 2024
@Abdurrahheem Abdurrahheem self-assigned this Apr 20, 2024
@Abdurrahheem Abdurrahheem marked this pull request as ready for review April 20, 2024 16:42
@fengyuentau
Copy link
Copy Markdown
Member

Some layers are expected to receive weight as inputs (no idea why that is needed) (MAJOR)

Most probably they need to be trainable. But we do not need to take care of this "trainable" feature.

@asmorkalov asmorkalov merged commit 4f81d78 into opencv:5.x Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants