Skip to content

New HAL API for remap#25399

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_remap
Apr 17, 2024
Merged

New HAL API for remap#25399
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_remap

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 11, 2024 •
edited
Loading

Address #25392

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 11, 2024
@asmorkalov asmorkalov force-pushed the as/HAL_remap branch 2 times, most recently from 506d2a6 to 9540edf Compare April 11, 2024 14:47
opencv-alalek
opencv-alalek reviewed Apr 11, 2024
View reviewed changes
modules/imgproc/src/imgwarp.cpp Outdated
src = src.clone();

if ((map1.type() == CV_32FC1) && (map2.type() == CV_32FC1))
CALL_HAL(remap, cv_hal_remap, src.type(), src.data, src.step, src.cols, src.rows, dst.data, dst.step, dst.cols, dst.rows,
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general HAL API should be called unconditionally.

Or we need to rename API and apply 32f suffix.

vpisarev
vpisarev reviewed Apr 12, 2024
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Apr 17, 2024

@opencv-alalek @vpisarev I fixed remarks:

  • Renamed HAL function with 32f prefix.
  • Stay with existing approach for border value like in other functions like warpAffine, warpPerspective.

@asmorkalov asmorkalov merged commit 577ad0a into opencv:4.x Apr 17, 2024
This was referenced Apr 19, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

@opencv-alalek opencv-alalek

Labels

category: imgproc feature optimization

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @vpisarev @opencv-alalek