Skip to content

Take first suitable neighbor in ChessBoardDetector::findQuadNeighbors#25365

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:take-first-suitable-neighbor-in-ChessBoardDetector-findQuadNeighbors
Apr 15, 2024
Merged

Take first suitable neighbor in ChessBoardDetector::findQuadNeighbors#25365
asmorkalov merged 1 commit intoopencv:4.xfrom
MaximSmolskiy:take-first-suitable-neighbor-in-ChessBoardDetector-findQuadNeighbors

Conversation

@MaximSmolskiy
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

Neighbors are sorted by distance in ascending order.

if (min_dist < FLT_MAX)
    CV_Assert(dist >= min_dist);

isn't triggered.

So, we always take first suitable neighbor and we can stop search after this.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested review from AleksandrPanov and asmorkalov and removed request for AleksandrPanov April 8, 2024 09:54
@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 8, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

@AleksandrPanov Please take a look.

Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This is a correct and useful change.

There are no regressions in the benchmark.

@asmorkalov asmorkalov merged commit c622ffd into opencv:4.x Apr 15, 2024
@MaximSmolskiy MaximSmolskiy deleted the take-first-suitable-neighbor-in-ChessBoardDetector-findQuadNeighbors branch April 15, 2024 11:38
@asmorkalov asmorkalov mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants