Take first suitable neighbor in ChessBoardDetector::findQuadNeighbors#25365
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Apr 15, 2024
Conversation
Contributor
|
@AleksandrPanov Please take a look. |
AleksandrPanov
approved these changes
Apr 15, 2024
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
👍
This is a correct and useful change.
There are no regressions in the benchmark.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
Neighbors are sorted by distance in ascending order.
isn't triggered.
So, we always take first suitable neighbor and we can stop search after this.
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.