Skip to content

HAL interface for bilaterialFilter#25343

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_bilaterialFilter
Apr 11, 2024
Merged

HAL interface for bilaterialFilter#25343
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_bilaterialFilter

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 5, 2024 •
edited
Loading

Fixes: #25344

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 5, 2024
@asmorkalov asmorkalov force-pushed the as/HAL_bilaterialFilter branch from 437d8cd to 86d3ef6 Compare April 5, 2024 11:12
@asmorkalov asmorkalov changed the title HALL interface for bilaterialFilter HAL interface for bilaterialFilter Apr 8, 2024
vpisarev
vpisarev reviewed Apr 10, 2024
View reviewed changes
@vpisarev
Copy link
Copy Markdown
Contributor

vpisarev commented Apr 10, 2024

generally, API is fine.
But we need to make a principal decision whether HAL functions should support external threading or they can do their own "parallel_for" (which may conflict with OpenCV's parallel for, e.g. OpenMP vs pthreads)

@asmorkalov asmorkalov force-pushed the as/HAL_bilaterialFilter branch from 86d3ef6 to cd394ec Compare April 11, 2024 05:47
@asmorkalov asmorkalov force-pushed the as/HAL_bilaterialFilter branch from cd394ec to 17c7f76 Compare April 11, 2024 06:02
@asmorkalov asmorkalov merged commit 2c5b296 into opencv:4.x Apr 11, 2024
@opencv-alalek opencv-alalek removed their request for review April 11, 2024 15:39
@asmorkalov asmorkalov mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev vpisarev left review comments

Assignees

No one assigned

Labels

category: imgproc optimization

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

Extend OpenCV HAL with bilaterialFilter

2 participants

@asmorkalov @vpisarev