support CXX compiler detection in CMake for visual studio 2022 preview#25341
Closed
pattakosn wants to merge 1 commit intoopencv:4.xfrom
pattakosn:vs2022preview-cmake-fix
Closed
support CXX compiler detection in CMake for visual studio 2022 preview#25341pattakosn wants to merge 1 commit intoopencv:4.xfrom pattakosn:vs2022preview-cmake-fix
pattakosn wants to merge 1 commit intoopencv:4.xfrom
pattakosn:vs2022preview-cmake-fix
Conversation
asmorkalov
approved these changes
Apr 8, 2024
Contributor
|
This is a preview release which content may be a subject of change. Consider passing |
|
Requesting to reopen now that MSVC 1940.X is out of preview. |
Contributor
|
Link is https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170 (look for 1940) This PR can't be reopened, need to submit a new PR UPDATE: DONE #25638 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
This is a proposed fix for the issue i reported last week
I am not aware of a naming/versioning scheme for MSVC versions so i looked for one and all i could find is this wikipedia list of compiler versions. Either they broke their rule of thumb to have a single 3rd digit for each VS version (eg 2015->190, 2017->191, etc) or they use +1 for the preview version which means that when VS2024++ with its matching new vc1x are released this change will need to be updated with the new vc and possibly a new entry for the next preview version.
Patch to opencv_extra has the same branch name.