Skip to content

support CXX compiler detection in CMake for visual studio 2022 preview#25341

Closed
pattakosn wants to merge 1 commit intoopencv:4.xfrom
pattakosn:vs2022preview-cmake-fix
Closed

support CXX compiler detection in CMake for visual studio 2022 preview#25341
pattakosn wants to merge 1 commit intoopencv:4.xfrom
pattakosn:vs2022preview-cmake-fix

Conversation

@pattakosn
Copy link
Copy Markdown

Pull Request Readiness Checklist

This is a proposed fix for the issue i reported last week
I am not aware of a naming/versioning scheme for MSVC versions so i looked for one and all i could find is this wikipedia list of compiler versions. Either they broke their rule of thumb to have a single 3rd digit for each VS version (eg 2015->190, 2017->191, etc) or they use +1 for the preview version which means that when VS2024++ with its matching new vc1x are released this change will need to be updated with the new vc and possibly a new entry for the next preview version.

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov self-assigned this Apr 9, 2024
@opencv-alalek
Copy link
Copy Markdown
Contributor

This is a preview release which content may be a subject of change.
Lets postpone change until the official release and official documentation.

Consider passing OpenCV_RUNTIME and OpenCV_ARCH variables through CMake command-line as workaround for preview.

@opencv-alalek opencv-alalek removed their request for review April 12, 2024 07:15
@asmorkalov asmorkalov closed this Apr 12, 2024
@viclabV1
Copy link
Copy Markdown

Requesting to reopen now that MSVC 1940.X is out of preview.

@opencv-alalek
Copy link
Copy Markdown
Contributor

opencv-alalek commented May 22, 2024

Link is https://learn.microsoft.com/en-us/cpp/overview/compiler-versions?view=msvc-170 (look for 1940)

This PR can't be reopened, need to submit a new PR


UPDATE: DONE #25638

@opencv-alalek opencv-alalek removed this from the 4.10.0 milestone May 22, 2024
@opencv-alalek opencv-alalek mentioned this pull request May 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants