Skip to content

Skip InferList.TestStreamingInfer#25321

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:skip_gapi_test
Apr 22, 2024
Merged

Skip InferList.TestStreamingInfer#25321
asmorkalov merged 1 commit intoopencv:4.xfrom
dkurt:skip_gapi_test

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Apr 3, 2024

Pull Request Readiness Checklist

similar workaround as #25294

resolves #25320

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov
Copy link
Copy Markdown
Contributor

@dkurt please let me know, when it's ready for merge.

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Apr 3, 2024

@asmorkalov, I have a concern that the test hangs not sporadically but because of memory issues. For example, after merge #25312 it executes fine. Let me move this PR to draft.

@dkurt dkurt marked this pull request as draft April 3, 2024 07:15
@dmatveev
Copy link
Copy Markdown
Contributor

dmatveev commented Apr 9, 2024

These tests shouldn't run at all with the newer versions of OpenVINO, @dkurt which OpenVINO version do you refer too?

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Apr 9, 2024

@dmatveev, Our actions CI still depend on OpenVINO 2023.0. Locally tests won't run with 2023.1

@dmatveev
Copy link
Copy Markdown
Contributor

@dmatveev, Our actions CI still depend on OpenVINO 2023.0. Locally tests won't run with 2023.1

@dkurt we can further lower down the check probably, to avoid the 2023.0 either. @TolyaTalamanov any ideas on this? Would it impact us much?

Meanwhile, there's OpenVINO 2024.0 already available and 2024.1 is coming soon.

Finally, the issue may be still irrelevant to the particular OpenVINO version or G-API's execution mechanics, let me prepare reproducer which will (sooner or later) hang without any of those components.

@asmorkalov
Copy link
Copy Markdown
Contributor

@dkurt @dmatveev The issue is still reproducible with CI and I often see test hangs. I have to merge the PR. Please submit another path with fix and enable test back.

@asmorkalov asmorkalov marked this pull request as ready for review April 22, 2024 08:43
@asmorkalov asmorkalov self-assigned this Apr 22, 2024
@asmorkalov asmorkalov merged commit 50b6edc into opencv:4.x Apr 22, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 22, 2024
@dmatveev
Copy link
Copy Markdown
Contributor

@asmorkalov no problem at all!

@dkurt dkurt deleted the skip_gapi_test branch April 24, 2024 06:45
@mshabunin mshabunin mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gapi accuracy test timeout sporadically: InferList.TestStreamingInfer

3 participants